LowExpiryCacheTime: improve handling of potential parse errors in eval-ed code#654
Merged
rebeccahum merged 1 commit intodevelopfrom Apr 15, 2021
Merged
Conversation
…led code Issue reported by GaryJones in Automattic/VIP-Coding-Standards 628#issuecomment-790653774 In rare cases, it is possible that the call to `eval()` with "safe" tokens only, would still result in a parse error. An example of such a case is when the PHP 5.6 `**` (`T_POW`) operator is used. PHPCS backfills the tokenization, which means that the operator is correctly recognized by the sniff as a "safe" token to use in the `eval()` statement. However, when the sniff is being run on PHP 5.4/5.5, the `eval()` will also be run on PHP 5.4/5.5 and while PHPCS backfills the token, PHP does not, resulting in a parse error in the `eval`-ed code, upon which the `eval()` will return `false`. This commit: * Silences the parse error notice. * Checks the output of the `eval()` for it being boolean `false` and if so, flags the statement for manual inspection, same as when any "non-safe" token is encountered.
GaryJones
approved these changes
Apr 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue reported by @GaryJones in #628 (comment)
In rare cases, it is possible that the call to
eval()with "safe" tokens only, would still result in a parse error.An example of such a case is when the PHP 5.6
**(T_POW) operator is used. PHPCS backfills the tokenization, which means that the operator is correctly recognized by the sniff as a "safe" token to use in theeval()statement.However, when the sniff is being run on PHP 5.4/5.5, the
eval()will also be run on PHP 5.4/5.5 and while PHPCS backfills the token, PHP does not, resulting in a parse error in theeval-ed code, upon which theeval()will returnfalse.This commit:
eval()for it being booleanfalseand if so, flags the statement for manual inspection, same as when any "non-safe" token is encountered.