Merged
Conversation
rebeccahum
force-pushed
the
2.3.0-changelog
branch
from
5d8ab5f to
7355f6f
Compare
jrfnl
requested changes
Apr 16, 2021
Collaborator
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Hi @rebeccahum I realize that the previous changelogs have been quite perfunctory, so feel free to ignore my suggestions if you think it makes the changelog too wordy.
On top of the remarks I've left in-line, one other thing:
Numerous entries mention "Ruleset: ...", but these entries do not specify whether this applies to the WordPressVIPMinimum ruleset or the WordPress-VIP-Go ruleset or both. Might be prudent to mention that in each of those cases.
GaryJones
requested changes
Apr 17, 2021
rebeccahum
force-pushed
the
2.3.0-changelog
branch
from
8a97af1 to
df4d67c
Compare
rebeccahum
force-pushed
the
2.3.0-changelog
branch
from
df4d67c to
55c11fe
Compare
GaryJones
approved these changes
Apr 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've left the breaking change in a note above the categories.