Skip to content

README: update for Composer 2.2#706

Merged
GaryJones merged 1 commit intodevelopfrom
feature/readme-update-for-composer-2.2
Jan 1, 2022
Merged

README: update for Composer 2.2#706
GaryJones merged 1 commit intodevelopfrom
feature/readme-update-for-composer-2.2

Conversation

@jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Dec 29, 2021

The dealerdirect/phpcodesniffer-composer-installer Composer plugin is a non-dev requirement for VIPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit adds the CLI command to set those permissions to the installation instructions.

Refs:

The `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is a non-dev requirement for VIPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit adds the CLI command to set those permissions to the installation instructions.

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
@jrfnl jrfnl added this to the 2.3.4 milestone Dec 29, 2021
@jrfnl jrfnl requested a review from a team as a code owner December 29, 2021 21:13
@GaryJones
Copy link
Contributor

Is this still needed if the composer.json has got the updated configuration?

@jrfnl
Copy link
Collaborator Author

jrfnl commented Dec 30, 2021

Is this still needed if the composer.json has got the updated configuration?

Yes, every project needs to give permission for plugins to run on their project. It's not as if the permission given in this project propagates to consumer projects (that would negate the security measure side of things as that way a dependency could still introduce the running of a malicious plugin without a project realizing).

Just to be sure, I did a test run anyway, with and without the config setting in this package, i.e. require automattic/vipwpcs:"2.3.3" (without) and require automattic/vipwpcs:"dev-master" (with) and yes, I got the prompt to grant permission in both cases.

@GaryJones GaryJones merged commit c4ffa53 into develop Jan 1, 2022
@GaryJones GaryJones deleted the feature/readme-update-for-composer-2.2 branch January 1, 2022 11:13
@rebeccahum
Copy link
Contributor

@GaryJones Do we need to update our public docs for installation instructions as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants