Merged
Conversation
jrfnl
reviewed
Dec 30, 2022
Collaborator
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Technically this change looks correct, but I can't test it as these scripts don't work on Windows anyway, so 🤷🏻♀️
GaryJones
commented
Jan 16, 2023
GaryJones
commented
Jan 16, 2023
rebeccahum
approved these changes
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the different logic for PHP 8.1 was in the GitHub workflow, moving it to the bin script means the GitHub workflow can be simplified, and the same Composer script can be run locally too.