Conversation
GaryJones
requested changes
Aug 23, 2023
Contributor
GaryJones
left a comment
GaryJones
left a comment
There was a problem hiding this comment.
I'm not worried about any duplicates in test files, but I think the ruleset should avoid duplicate entries.
…sn't exist PHP does not contain a `delete()` function, so searching for it will only yield false positives. Ref: https://www.php.net/manual/en/function.delete.php
jrfnl
force-pushed
the
fix/remove-non-existent-function
branch
from
756b1a5 to
5a56060
Compare
GaryJones
approved these changes
Aug 23, 2023
Contributor
GaryJones
left a comment
GaryJones
left a comment
There was a problem hiding this comment.
Thanks for updating! ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP does not contain a
delete()function, so searching for it will only yield false positives.Ref: https://www.php.net/manual/en/function.delete.php