Conversation
As per the thread in 740, these functions all return the full path to a file, so these should all be fine. As things were, use of these in an `include`/`require` statement would throw an unjustified "Absolute include path must be used" warning. Includes a few extra tests, though I didn't think it would be necessary to have tests with each of these functions. Fixes 740
GaryJones
deleted the
fix/740-includingfile-prevent-some-false-positives
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files/IncludingFile: alphabetize the list of path functions
Files/IncludingFile: allow for more path-returning functions
As per the thread in #740, these functions all return the full path to a file, so these should all be fine.
As things were, use of these in an
include/requirestatement would throw an unjustified "Absolute include path must be used" warning.Includes a few extra tests, though I didn't think it would be necessary to have tests with each of these functions.
Fixes #740