Classes/DeclarationCompatibility: remove redundant code#768
Merged
Classes/DeclarationCompatibility: remove redundant code#768
Conversation
The `$functionList` property is only ever written to, never _read_, so all that work walking all the tokens in the complete class scope is redundant (and was done in a highly inefficient way in the first place). So, removing all code related to the property should improve performance of the sniff a little.
GaryJones
approved these changes
Aug 23, 2023
Contributor
GaryJones
left a comment
GaryJones
left a comment
There was a problem hiding this comment.
I wonder if this was meant to be used in a later development.
Collaborator
Author
Quite possibly or a left-over of something removed. I did try to do a trace back, but it came in with the initial import from SVN, so I couldn't trace the history back any further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
$functionListproperty is only ever written to, never read, so all that work walking all the tokens in the complete class scope is redundant (and was done in a highly inefficient way in the first place).So, removing all code related to the property should improve performance of the sniff a little.