Conversation
GaryJones
force-pushed
the
release/3.0.0-changelog
branch
from
8af80c9 to
794b9d9
Compare
jrfnl
reviewed
Sep 4, 2023
Collaborator
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
@GaryJones Thanks for setting this up.
Verified that all merged PRs are mentioned ✔️
Additional notes:
- "Props" are missing. Not something I'm really concerned about as it's only the two of us, but all previous changelogs have them, so for consistency, it should be there.
- I would mention the branch "rename" in the intro at the top as well.
Also: the branch rename has not been done in a typical rename manner, but has added amainbranch instead. This is good in that it won't accidentally break CI for any repo now usingmaster, but that makes it all the more important to signal thatmainshould be used from now on. - In most cases, the issue number/link goes to the PR, though sometimes to an underlying issue.
Would it be an idea to use a consistent pattern ?
Maybe something like[PR link]: description. Fixes [issue link], [issue link]?
GaryJones
force-pushed
the
release/3.0.0-changelog
branch
from
794b9d9 to
1080d56
Compare
Contributor
Author
|
@jrfnl PR updated with your suggestions :-) |
jrfnl
approved these changes
Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.