Skip to content

Display who will be notified of post status changes#453

Closed
WPprodigy wants to merge 9 commits intomasterfrom
feature/270-subscribed-to-status-changes
Closed

Display who will be notified of post status changes#453
WPprodigy wants to merge 9 commits intomasterfrom
feature/270-subscribed-to-status-changes

Conversation

@WPprodigy
Copy link
Copy Markdown
Contributor

Part of #270. This PR started in #272, and is continued with some edits here.

To test:

  1. Enable Subscribers feature.
  2. Subscribe some users and/or groups to a post.
  3. Check the posts submit box to ensure it shows the correct counts and updates accordingly.

Screenshots can be found in #272, as there weren't many changes to the display.

goodguyry and others added 9 commits July 29, 2014 22:54
This event is added in another PR as well, so will probably be a merge conflict?
Simplify the logic and adhere to WP coding standards.
1) Remove underline - it doesn’t play too nice with other plugins.

2) Fix styling so the edit link is not bold.

3) Code standards clean up.
@WPprodigy
Copy link
Copy Markdown
Contributor Author

Probably worth noting that the following_list_updated custom jQuery trigger is used/added in both PRs. So will need to deal with that merge conflict likely when it comes time to merge them both.

Copy link
Copy Markdown
Contributor

@sboisvert sboisvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, Should we add this and the other PRs that relate to notifications to a feature branch and try to get it in 0.9? cc @rinatkhaziev @philipjohn

@jerclarke
Copy link
Copy Markdown
Contributor

jerclarke commented Nov 9, 2018

First, thanks to @goodguyry and @WPprodigy for getting this working based on my initial request, very nice!

That said, after looking at the screenshots in #272 I am doubting the value of this change, at least in it's current form.

Screenshot from #272:
image

Having the list take up space in the submitbox, just to list the count of users and groups, seems like a waste of extremely valuable real-estate (We have other editorial stuff in that space, and Edit Flow potentially adds two other metaboxes immediately

If we keep it, the whole list of people would be more useful

I'd much rather have the full list of people who will be notified, as in the New Editorial Comment UI, as that lets you confirm your expectations about who is subscribed. Showing just the counts means it's still easy to think someone is subscribed who isn't.

Isn't it weird that we don't say what they are following?

Even when I consider having it show the full list of subscribers, it still seems weird, because we aren't saying what will happen. When will these people be notified? I know we know the answer, but users won't necessarily. By comparison, in the Editorial Comment box it's so explicit why the list is being shown: Submit this comment, these people get email. This submitbox use case is a lot weirder.

The bright side is the Edit button, which is genuinely useful. Our Notifications metabox is buried real deep on the screen, so having a shortcut to it is genuinely valuable.

It should say Notifications rather than Followers

Also FWIW I'd really rather avoid "Follower" as a new word for this context. Currently there's no use of that word in the post editor in the context of the Notifications or Editorial Comments metaboxes. The ticked users are just people who will be notified.

Personally I think of them as "subscribers" rather than "followers", but as far as the post editor is concerned, neither of those words is part of the vocabulary yet. Follower somehow strikes me as wrong because people are automatically subscribed (when they edit) and subscribed by others (having their name ticked) so often. "Is following" feels like an active verb compared to "being subscribed" which describes the situation better.

Either way, having "Followers" up in the top, without listing them, I think will be genuinely confusing. It sounds like a Twitter integration or something.

IMHO the best label to go there is simply Notifications, which matches the metabox that Edit links to, and uses the word we already use for ticked users. In terms of "what does this list do?" as a user question, I think Notifications works just as well or better than "Followers" because it clarifies that this is the list of people who will be notified about the post overall, so if you know what notifications get emitted, then you know those people should get them.

TL;DR: As the person who requested this feature as part of #270, I'm not totally convinced this is necessary. If we want to keep it, I think we should show the full list of users, and that it should say Notifications to match the metabox, rather than Followers which would be a new word for this feature.

@WPprodigy
Copy link
Copy Markdown
Contributor Author

I am doubting the value of this change, at least in it's current form.

I'm not totally convinced this is necessary. If we want to keep it, I think we should show the full list of users.

I'm more-so leaning towards dropping this. I'm not sure it carries enough usefulness, and also there is GB to consider fairly soon. I think the Follower information should just be kept together and found in one place.

So +1 for passing on this. CC @sboisvert

@rinatkhaziev
Copy link
Copy Markdown
Contributor

Based on consensus in this discussion, closing this.

@htdat htdat deleted the feature/270-subscribed-to-status-changes branch April 22, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants