Display who will be notified of post status changes#453
Display who will be notified of post status changes#453
Conversation
This event is added in another PR as well, so will probably be a merge conflict?
Simplify the logic and adhere to WP coding standards.
1) Remove underline - it doesn’t play too nice with other plugins. 2) Fix styling so the edit link is not bold. 3) Code standards clean up.
|
Probably worth noting that the |
sboisvert
left a comment
There was a problem hiding this comment.
This looks good to me, Should we add this and the other PRs that relate to notifications to a feature branch and try to get it in 0.9? cc @rinatkhaziev @philipjohn
|
First, thanks to @goodguyry and @WPprodigy for getting this working based on my initial request, very nice! That said, after looking at the screenshots in #272 I am doubting the value of this change, at least in it's current form.
Having the list take up space in the submitbox, just to list the count of users and groups, seems like a waste of extremely valuable real-estate (We have other editorial stuff in that space, and Edit Flow potentially adds two other metaboxes immediately If we keep it, the whole list of people would be more usefulI'd much rather have the full list of people who will be notified, as in the New Editorial Comment UI, as that lets you confirm your expectations about who is subscribed. Showing just the counts means it's still easy to think someone is subscribed who isn't. Isn't it weird that we don't say what they are following?Even when I consider having it show the full list of subscribers, it still seems weird, because we aren't saying what will happen. When will these people be notified? I know we know the answer, but users won't necessarily. By comparison, in the Editorial Comment box it's so explicit why the list is being shown: Submit this comment, these people get email. This submitbox use case is a lot weirder. The bright side is the It should say
|
I'm more-so leaning towards dropping this. I'm not sure it carries enough usefulness, and also there is GB to consider fairly soon. I think the Follower information should just be kept together and found in one place. So +1 for passing on this. CC @sboisvert |
|
Based on consensus in this discussion, closing this. |

Part of #270. This PR started in #272, and is continued with some edits here.
To test:
Screenshots can be found in #272, as there weren't many changes to the display.