Changed $_REQUEST usage to $_POST usage in handle_notepad_update()#470
Merged
sboisvert merged 1 commit intoAutomattic:masterfrom Jun 5, 2018
TheCrowned:update/dashboard-notepad-superglobals
Merged
Changed $_REQUEST usage to $_POST usage in handle_notepad_update()#470sboisvert merged 1 commit intoAutomattic:masterfrom TheCrowned:update/dashboard-notepad-superglobals
sboisvert merged 1 commit intoAutomattic:masterfrom
TheCrowned:update/dashboard-notepad-superglobals
Conversation
…pdate(). This expects the HTML form to use the POST method.
Contributor
|
Looks good, great commit message! One thing that we could add is that it might be useful in the note to state what commit / PR # this depends on. (It's can be deduced from the rest of the text that it depends on #469 but it could be useful to have really stand out so folks skimming it quickly still catch it. |
Contributor
Author
|
All right - I have added the mention to the other PR on which this one depends on :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
handle_notepad_update()used to use$_REQUEST, which is against best practices.Before #469, the form did not specify a method so it defaulted to GET. With #469, we changed the method to POST, so all references to
$_REQUESThave been updated with the corresponding$_POSTones.NOTE that this depends on #469, because it expects the HTML form to use the POST method, or the note saving will just not work.