Skip to content

Remove auto-subscribe of current users to post notifications#520

Closed
mikeyarce wants to merge 1 commit intomasterfrom
remove-current-user-notification
Closed

Remove auto-subscribe of current users to post notifications#520
mikeyarce wants to merge 1 commit intomasterfrom
remove-current-user-notification

Conversation

@mikeyarce
Copy link
Copy Markdown
Contributor

This change means the current user will no longer be auto-subscribed to post notifications when actions are taken on a post.

This change means the current user will no longer be auto-subscribed to post notifications when actions are taken on a post.
@mikeyarce mikeyarce requested a review from anigeluk August 22, 2019 21:45
@jerclarke
Copy link
Copy Markdown
Contributor

Okay Mikey and I discussed this on slack but I'll say it again for anyone else:

I don't think removing this feature entirely is a good approach. My users take advantage of this "auto-subscribe on post edit" feature all the time and we would never want to turn it off.

The filter already offers a way to disable it for a given site.

If anything I would support a setting in the Notifications section of EF options to disable this, as well as one to disable "author is always auto-subscribed". I welcome and enjoy both of those features, but I can see why others would want an easy way to turn them off.

That said there's a separate bug that makes this situation worse: It seems to be impossible to untag yourself from a post. When I uncheck my box after being auto-subscribed it flashes green and the box returns unchecked, but reloading the page shows me checked again. Not a good situation at all. Clearly a bug.

Need to confirm how general this problem is, but it makes sense that people are annoyed by the auto-subscribe-on-edit if there's no way to undo it!

@dchymko
Copy link
Copy Markdown
Contributor

dchymko commented Oct 31, 2019

That said there's a separate bug that makes this situation worse: It seems to be impossible to untag yourself from a post. When I uncheck my box after being auto-subscribed it flashes green and the box returns unchecked, but reloading the page shows me checked again. Not a good situation at all. Clearly a bug.

This bug has been addressed in #540. As far as the bigger issue around adding the ability to customize notifications, perhaps we can create that as an enhancement issue.

@dchymko dchymko closed this Oct 31, 2019
@dchymko dchymko deleted the remove-current-user-notification branch October 31, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants