Skip to content

Prevent js errors when scheduling / trashing post #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjangda merged 1 commit into from
Nov 25, 2019
Merged

Prevent js errors when scheduling / trashing post #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
241 changes: 240 additions & 1 deletion blocks/dist/custom-status.build.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 12 additions & 7 deletions blocks/src/custom-status/block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,16 @@ let { SelectControl } = wp.components;
*/
let statuses = window.EditFlowCustomStatuses.map( s => ({ label: s.name, value: s.slug }) );

let getStatusLabel = slug => statuses.find( s => s.value === slug ).label;

// Hack :(
// @see https://github.com/WordPress/gutenberg/issues/3144
let sideEffectL10nManipulation = status => {
/**
* Hack :(
*
* @see https://github.com/WordPress/gutenberg/issues/3144
*
* Gutenberg overrides the label of the Save button after save (i.e. "Save Draft"). But there's no way to subscribe to a "post save" message.
*
* So instead, we're keeping the button label generic ("Save"). There's a brief period where it still flips to "Save Draft" but that's something we need to work upstream to find a good fix for.
*/
let sideEffectL10nManipulation = () => {
let node = document.querySelector('.editor-post-save-draft');
if ( node ) {
document.querySelector( '.editor-post-save-draft' ).innerText = `${ __( 'Save' ) }`
Expand Down Expand Up @@ -46,7 +51,7 @@ subscribe( function () {
// Update the "Save" button.
var status = select( 'core/editor' ).getEditedPostAttribute( 'status' );
if ( typeof status !== 'undefined' && status !== 'publish' ) {
sideEffectL10nManipulation( getStatusLabel( status ) );
sideEffectL10nManipulation();
}
} );

Expand Down Expand Up @@ -83,7 +88,7 @@ const mapDispatchToProps = ( dispatch ) => {
return {
onUpdate( status ) {
dispatch( 'core/editor' ).editPost( { status } );
sideEffectL10nManipulation( getStatusLabel( status ) );
sideEffectL10nManipulation();
},
};
};
Expand Down