Conversation
cojennin
force-pushed
the
update/dockerize-testing
branch
2 times, most recently
from
6d53ffd to
3df4563
Compare
Contributor
Author
|
The E2E test will continue to fail until #560 is merged in, the E2E tests delete all posts before running the tests, but the delete action is throwing a WSOD because of the notice from #560 (see screenshot) which prevents the E2E tests from completing (causing the failure)
|
Closed
cojennin
force-pushed
the
update/dockerize-testing
branch
from
3df4563 to
322e4c6
Compare
cojennin
force-pushed
the
update/dockerize-testing
branch
5 times, most recently
from
1a02038 to
f7c56e4
Compare
Contributor
Author
|
Includes a quick update to some tests that were causing test failures in PHPUnit |
cojennin
force-pushed
the
update/dockerize-testing
branch
from
f7c56e4 to
6fc60de
Compare
mjangda
previously approved these changes
Dec 18, 2019
Member
mjangda
left a comment
mjangda
left a comment
There was a problem hiding this comment.
This is awesome! Spotted one small thing.
…-Flow into update/dockerize-testing
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerizes testing on Travis (and locally) based on Gutenberg.
Adds an E2E test to confirm E2E testing works and the plugin is loaded.