Statuses for Story Budget and Calendar should be Edit Flow specific s…#595
Merged
Statuses for Story Budget and Calendar should be Edit Flow specific s…#595
Conversation
cojennin
force-pushed
the
fix/status-filter-dropdowns
branch
from
8c3d482 to
0438c2e
Compare
…tatuses unless otherwise filtered
cojennin
force-pushed
the
fix/status-filter-dropdowns
branch
from
0438c2e to
adeafe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(#446) fixed an issue where Edit Flow was preventing other custom statuses from appearing in the status column for a post type, which makes sense.
However, for Calendar and Story Budget, you can end up with the following:
These are statuses from WooCommerce in the Story Budget dropdown, and they persist even after the WooCommerce plugin is disabled. This makes the dropdown a little confusing (in this case, for folks who might have an e-commerce site with a content marketing arm that uses Edit Flow).
This PR cleans up some logic around the post status filters for Calendar and Story Budget, and also provides a way for folks to hook into Calendar and Story Budget status filers so folks can provide their own