Skip to content

Fix failing GitHub e2e tests#722

Merged
alecgeatches merged 20 commits intodevelopfrom
fix/gh-actions
May 21, 2024
Merged

Fix failing GitHub e2e tests#722
alecgeatches merged 20 commits intodevelopfrom
fix/gh-actions

Conversation

@alecgeatches
Copy link
Copy Markdown
Contributor

@alecgeatches alecgeatches commented May 20, 2024

As a first step for modernization, this PR:

  • Fixes end-to-end tests. Most of these failures were due to old CSS selectors that no longer work with modern WordPress admin components. All existing end to end tests should now pass.
  • Updates the lowest supported PHP version to 7.4, and removes testing for lower versions.
  • Explicitly uses a .nvmrc to mark the node version of 14. We'll want to move this to a modern version (20) soon.
  • Removes eslines from npm lint-js. eslines is an Automattic utility that seemed to be used to ignore linting errors also in the master branch, but was throwing errors and blocking tests. As it's close to 3 years out of date, I just dropped the usage and allowed eslint tests to fail. We'll come back to these very soon to --fix, ignore, and manually fix the remaining errors.

@alecgeatches alecgeatches self-assigned this May 20, 2024
@alecgeatches alecgeatches changed the title Fix failing GitHub action tests Fix failing GitHub e2e tests May 20, 2024
@alecgeatches alecgeatches marked this pull request as ready for review May 20, 2024 22:35
@alecgeatches
Copy link
Copy Markdown
Contributor Author

End to end tests are now passing! See the last run: https://github.com/Automattic/Edit-Flow/actions/runs/9165713334/job/25199719325

The lint-js task has been moved to run after jest and end-to-end tests. We'll come back to address the tons of linting warnings and errors very soon.

@alecgeatches
Copy link
Copy Markdown
Contributor Author

Hello @rebeccahum! We're doing some refactorings starting with fixing end-to-end tests in GitHub Actions and a PHP version bump. Please take a look! We'll plan to do a new plugin release once we're done with modernization work.

Copy link
Copy Markdown
Contributor

@ingeniumed ingeniumed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth switching the branch it's going to, to be a release branch? That way, once we wrap up our modernization changes we can make a single merge of that into the main branch and cut the release. There's going to be another breaking change after this so figured do it one go.

@alecgeatches alecgeatches changed the base branch from master to develop May 21, 2024 17:20
@alecgeatches
Copy link
Copy Markdown
Contributor Author

@ingeniumed I'm going to merge this into a new develop branch. Thank you!

@alecgeatches alecgeatches merged commit 98999f2 into develop May 21, 2024
@alecgeatches alecgeatches deleted the fix/gh-actions branch May 21, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants