Fix failing GitHub e2e tests#722
Conversation
|
End to end tests are now passing! See the last run: https://github.com/Automattic/Edit-Flow/actions/runs/9165713334/job/25199719325 The |
|
Hello @rebeccahum! We're doing some refactorings starting with fixing end-to-end tests in GitHub Actions and a PHP version bump. Please take a look! We'll plan to do a new plugin release once we're done with modernization work. |
ingeniumed
left a comment
There was a problem hiding this comment.
Would it be worth switching the branch it's going to, to be a release branch? That way, once we wrap up our modernization changes we can make a single merge of that into the main branch and cut the release. There's going to be another breaking change after this so figured do it one go.
|
@ingeniumed I'm going to merge this into a new |
As a first step for modernization, this PR:
7.4, and removes testing for lower versions..nvmrcto mark the node version of14. We'll want to move this to a modern version (20) soon.eslinesfromnpm lint-js.eslinesis an Automattic utility that seemed to be used to ignore linting errors also in themasterbranch, but was throwing errors and blocking tests. As it's close to 3 years out of date, I just dropped the usage and allowedeslinttests to fail. We'll come back to these very soon to--fix, ignore, and manually fix the remaining errors.