Lint the common modules#738
Merged
ingeniumed merged 1 commit intodevelopfrom Jul 2, 2024
Merged
Conversation
hanifn
approved these changes
Jul 2, 2024
Contributor
hanifn
left a comment
hanifn
left a comment
There was a problem hiding this comment.
Looks good. Just have a non-blocking question.
| $url = trailingslashit(get_permalink()) . user_trailingslashit("$wp_rewrite->pagination_base/" . $i, 'single_paged'); | ||
| else | ||
| $url = trailingslashit(get_permalink()) . user_trailingslashit($i, 'single_paged'); | ||
| } else if ( 'page' == get_option( 'show_on_front' ) && get_option( 'page_on_front' ) == $post->ID ) { |
Contributor
There was a problem hiding this comment.
Have we ever decided between else if vs elseif? Because I think there have been a PR or 2 before this where we've changed else if to elseif. 🤔
Contributor
Author
There was a problem hiding this comment.
Don't think so, though I'm not pedantic about that. I've always been used to writing else if hence why I stuck with it
GaryJones
added
the
type: maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will lint the two common modules that were skipped out on, in the previous PR. It's mainly spacing changes really so it's safe to do so and I ensure this won't be ignored in the future.
Steps to Test