fix(vscode): pre-select current dialect in the dialect picker#3198
Open
LanceYing2004 wants to merge 1 commit intoAutomattic:masterfrom
Open
fix(vscode): pre-select current dialect in the dialect picker#3198LanceYing2004 wants to merge 1 commit intoAutomattic:masterfrom
LanceYing2004 wants to merge 1 commit intoAutomattic:masterfrom
Conversation
Collaborator
|
See also: #3181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-04-17.at.17.31.35.mov
…(#2667)
Issues
Previously, clicking the dialect indicator in the status bar would always show the picker with
"American"selected by default, even when the active document was already using another dialect such as British or Canadian. This made the UI inconsistent with the actual document state.Description
This PR fixes the VS Code dialect picker so that it opens with the current document dialect highlighted, instead of always starting with US/American.
QuickPickinstance so the current dialect can be preselected/highlighted when the menu opensDemo
Video demo has been attached.
How Has This Been Tested?
I tested this change manually in the VS Code Extension Development Host.
I specifically verified:
Checklist