feat(harper-core): Mark shebangs as unlintable#421
feat(harper-core): Mark shebangs as unlintable#421sohunpatel wants to merge 1 commit intoAutomattic:masterfrom sohunpatel:master
Conversation
|
I think a better solution would be to mask them out in harper-tree-sitter. See fd5ebae. |
|
@grantlemons, @sohunpatel I think the best way to do this would be to create a new implementaion of the Let me know if you have any questions about any of that. |
|
I may tackle this eventually, but it doesn't seem that this PR is getting more attention. Since it is still not in a satisfactory state, I'm going to close it. |
@elijah-potter How strongly do you feel about this approach? I'm currently testing out a one-line change which modifies harper-comments/src/masker.rs and I think this would be a bit simpler than creating a new |
|
@holman, that depends on what the one-line change looks like. Why don't you open a draft PR and we can take a look? |
Closes #65.
Changes
I am not sure if this is a great solution since this should only apply to comment parsers, but I could not find an elegant solution for that.