feat(core): Lint for those who don't like Oxford commas

[hippietrail]

I do use them, but many dislike them.
As I noted on issue #355 (comment)

[hippietrail]

Since there is not yet any mutual-exclusive switch for opposing preferences, both "Oxford comma" and "No Oxford comma" can be active at once. A side-effect is any lists not flagged for either probably indicate some imperfection in the sentence parsing.

[elijah-potter]

I'm quite tempted to merge this. Once I do, @hippietrail would you mind using Harper with this linter enabled for a few days to catch any issues? If you find any, we can open a new PR with fixes.

[hippietrail]

I'm quite tempted to merge this. Once I do, @hippietrail would you mind using Harper with this linter enabled for a few days to catch any issues? If you find any, we can open a new PR with fixes.

Absolutely! You may notice I filed a number of issues with other linters yesterday.

[elijah-potter]

Fantastic. Merging...

[hippietrail]

Fantastic. Merging...

Try as I might I cannot get it to work now in VS Code or Windsurf. It does work with harper-cli though.
Could it be related to there not being an option in the settings for NoOxfordComma?

???

As I came to write this it has now flipped and it's only flagging the sentences with Oxford commas and not the ones without. It's almost 1am so maybe I'm just missing something. I'm going to sleep on it but would be great if somebody could test on their system.

[mcecode]

Try as I might I cannot get it to work now in VS Code or Windsurf. It does work with harper-cli though. Could it be related to there not being an option in the settings for NoOxfordComma?

It should still work as long as the default setting for NoOxfordComma is true in your harper-ls build. If you'd like there to be a setting for it within VSCode when you're trying it out in the extension host, you can run just update-vscode-linters to add any missing linters that's in the current master build but not in the latest release before opening the extension host.

[hippietrail]

just update-vscode-linters

I just committed what I was working on to go back to master to see if it's still happening. And I now have two pinned cores. just update-vscode-linters and reloading the window did not make both Oxford lints work again.

I wonder if switching branches with harper-cli running is causing the pinned cores, and that in turn might be causing the old harper-cli to still be running instead of the updated one with both the "Oxford" and "no Oxford" lints?

[mcecode]

Sorry it took me a while to get back to you on this.

I just committed what I was working on to go back to master to see if it's still happening. And I now have two pinned cores. just update-vscode-linters and reloading the window did not make both Oxford lints work again.

just update-vscode-linters is only meant to allow you to set the new NoOxfordComma rule within VSCode. Did the Oxford comma lints not work despite setting both of them to true within VSCode?

I wonder if switching branches with harper-cli running is causing the pinned cores, and that in turn might be causing the old harper-cli to still be running instead of the updated one with both the "Oxford" and "no Oxford" lints?

So are you having problems with harper-cli now or did you mean harper-ls when you said harper-cli? If it's the latter, yes, changing branches and running different/old versions of harper-ls may be what's causing the Oxford comma lints to not work.

[hippietrail]

Sorry it took me a while to get back to you on this.

I just committed what I was working on to go back to master to see if it's still happening. And I now have two pinned cores. just update-vscode-linters and reloading the window did not make both Oxford lints work again.

just update-vscode-linters is only meant to allow you to set the new NoOxfordComma rule within VSCode. Did the Oxford comma lints not work despite setting both of them to true within VSCode?

I wonder if switching branches with harper-cli running is causing the pinned cores, and that in turn might be causing the old harper-cli to still be running instead of the updated one with both the "Oxford" and "no Oxford" lints?

So are you having problems with harper-cli now or did you mean harper-ls when you said harper-cli? If it's the latter, yes, changing branches and running different/old versions of harper-ls may be what's causing the Oxford comma lints to not work.

harper-cli always worked for both OxfordComma and NoOxfordComma. But harper-ls Would only work with one until suddenly it switched to only working with the other. But now they are both working. It seemed odd that killing the harper-ls processes after changing branches didn't fix. I may have mixed them up when I was at my most frustrated and confused.

[NicholasFlamy]

In VSCodium, it doesn't tell me to remove it with this option disable, but it does tell me to add it with this option enabled. Luckily I'm for Oxford commas, so I'm happy.

[hippietrail]

In VSCodium, it doesn't tell me to remove it with this option disable, but it does tell me to add it with this option enabled. Luckily I'm for Oxford commas, so I'm happy.

Until now I only had one of the Oxford comma options show up, but now I see both at last.
Though now I see some other problems... will report...