Google Fonts: fix warning when webfonts API not available#23306
Closed
creativecoder wants to merge 3 commits into
Closed
Google Fonts: fix warning when webfonts API not available#23306creativecoder wants to merge 3 commits into
creativecoder wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
[Plugin] Jetpack
creativecoder
changed the title
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
github-actions
Bot
added
[Status] Needs Author Reply
creativecoder
added
[Status] Needs Review
jeherve
added
[Package] Google Fonts Provider
jeherve
added a commit
that referenced
this pull request
Mar 9, 2022
jeherve
added
[Pri] Normal
[Status] Blocked / Hold
and removed
[Status] In Progress
[Status] Needs Review
Contributor
Author
|
That approach looks good--let's go with that! |
kraftbj
added a commit
that referenced
this pull request
Mar 14, 2022
…n. (#23322) * Google Fonts: update method used to preconnect Fonts source domain Follow-up to #23045 Let's favor using a Core implementation with a Core filter instead of manually adding to the head. * Use filter instead of action * Only add resource hint if the site supports the Webfonts API See #23306 * Update readme with latest method name. * Introduce new class that doesn't depend on WP_Webfonts_Provider WP_Webfonts_Provider may not always be available, so we cannot call a method from a child class of `WP_Webfonts_Provider` from a WP filter. Let's introduce a new class instead, that doesn't depend on anything, and do the class check inside there. That should simplify things a bit for the folks having to implement that filtering. Co-authored-by: Brandon Kraft <public@brandonkraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow up to #23045
Prevents a warning when the Webfonts API is not available (from the Gutenberg plugin).
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
See #23045 for more detalis.