Skip to content

feat: Editor assets endpoint allows the VideoPress block#45255

Draft
dcalhoun wants to merge 12 commits intotrunkfrom
feat/editor-assets-endpoint-allows-videopress
Draft

feat: Editor assets endpoint allows the VideoPress block#45255
dcalhoun wants to merge 12 commits intotrunkfrom
feat/editor-assets-endpoint-allows-videopress

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Sep 19, 2025

Ref CMM-713.

Proposed changes:

Allow the videopress/video block type for the GutenbergKit mobile app editor.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pbArwn-7AD-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Apply these Jetpack changes to your site (see comment).
  2. Make a request to the /wpcom/v2/sites/<site_id>/editor-assets endpoint for the WPCOM site—via API Console, curl, etc.
  3. Verify the 200 response includes the videopress/video block type within the allow_block_types.

@dcalhoun dcalhoun added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Feature] WP REST API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the feat/editor-assets-endpoint-allows-videopress branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack feat/editor-assets-endpoint-allows-videopress

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: March 3, 2026
    • Code freeze: March 3, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Sep 19, 2025

Code Coverage Summary

No summary data is available for parent commit 5d53688, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 5d53688 is available.

Full summary · PHP report · JS report

@github-actions
Copy link
Contributor

This PR has been marked as stale. This happened because:

  • It has been inactive for the past 3 months.
  • It hasn't been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Status] Keep Open`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

@dcalhoun dcalhoun force-pushed the refactor/videopress-utilizes-api-fetch-utility branch from 77dd37b to bf835ce Compare November 26, 2025 17:59
@dcalhoun dcalhoun force-pushed the feat/editor-assets-endpoint-allows-videopress branch from 7c65124 to 0eec284 Compare November 26, 2025 17:59
@dcalhoun dcalhoun force-pushed the refactor/videopress-utilizes-api-fetch-utility branch from bf835ce to c3a846e Compare January 12, 2026 15:38
@dcalhoun dcalhoun force-pushed the feat/editor-assets-endpoint-allows-videopress branch from 0eec284 to 2ebdfb2 Compare January 12, 2026 15:39
@dcalhoun dcalhoun force-pushed the refactor/videopress-utilizes-api-fetch-utility branch from c3a846e to 7615fb4 Compare January 12, 2026 18:05
@dcalhoun dcalhoun force-pushed the feat/editor-assets-endpoint-allows-videopress branch from 2ebdfb2 to b5d50be Compare January 12, 2026 18:06
@dcalhoun dcalhoun force-pushed the refactor/videopress-utilizes-api-fetch-utility branch from 7615fb4 to 198018c Compare January 13, 2026 16:48
@dcalhoun dcalhoun force-pushed the feat/editor-assets-endpoint-allows-videopress branch from b5d50be to d56e487 Compare January 13, 2026 16:48
@dcalhoun dcalhoun force-pushed the refactor/videopress-utilizes-api-fetch-utility branch from 198018c to 6d335b5 Compare January 13, 2026 17:21
@dcalhoun dcalhoun force-pushed the feat/editor-assets-endpoint-allows-videopress branch from d56e487 to cf08962 Compare January 13, 2026 17:22
Allow authenticating for `admin-ajax` and post preview requests with
application passwords. This enables cookie-less clients--e.g, the iOS
and Android mobile apps--to successfully authenticate these requests.
Return early if the provided value is already truthy.
The logic now requires the `preview` parameter.
Mitigate potential security risk by limiting application password
capabilities to VideoPress-related AJAX actions.
Utilize the `@wordpress/api-fetch` utility to align with WordPress core
and enable usage of its functionality. Namely, leveraging middleware for
configuring requests.
@dcalhoun dcalhoun force-pushed the refactor/videopress-utilizes-api-fetch-utility branch from 6d335b5 to 57be191 Compare February 12, 2026 16:51
@dcalhoun dcalhoun force-pushed the feat/editor-assets-endpoint-allows-videopress branch from cf08962 to ae35d6d Compare February 12, 2026 16:51
The `get-media-token` logic is utilized in a lot of contexts--WP Admin,
site front end, etc. We cannot rely upon `apiFetch` universally, as it
is unavailable in some of these contexts. This resulted in the error
below.

```
[Error] TypeError: undefined is not an object (evaluating 'window.wp.apiFetch')
```

Adding `@wordpress/api-fetch` as a dependency is a non-starter as it
would unnecessarily increase the bundle size. Instead, we scope the
`apiFetch` usage to GutenbergKit, where it is available and needed for
token authentication through middleware. This also reduces the overall
reach of the changes.
@dcalhoun dcalhoun force-pushed the feat/editor-assets-endpoint-allows-videopress branch from ae35d6d to 8dd337f Compare February 13, 2026 15:18
@dcalhoun dcalhoun force-pushed the refactor/videopress-utilizes-api-fetch-utility branch from 57fdcbd to 8c890f9 Compare February 23, 2026 20:26
Base automatically changed from refactor/videopress-utilizes-api-fetch-utility to trunk February 23, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] WP REST API [Package] VideoPress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant