Remove the last glib calls, replace with libicu#1985
Closed
chearon wants to merge 1 commit intoAutomattic:masterfrom
Closed
Remove the last glib calls, replace with libicu#1985chearon wants to merge 1 commit intoAutomattic:masterfrom
chearon wants to merge 1 commit intoAutomattic:masterfrom
Conversation
Collaborator
Author
|
I ended up doing the important parts of this in #1987, we can figure the libicu nightmare when the time comes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes some GLib call, replaces others with libicu. We might eventually not need Pango, at which point we could remove GLib. If we remove Pango, libicu would also be needed for grapheme iteration for font fallbacks. All operating systems come with libicu, so I thought this would be easy, but it was a pain. macOS doesn't expose headers, so we have to use the homebrew version. Windows uses different naming, and the blocker: it compiles but crashes on startup.
I'm stumped on Windows but I'll try more later, for now I wanted to get this opened.