Skip to content

Replace empty screen with add site flow and rename it to NoStudioSites#2149

Merged
sejas merged 20 commits intotrunkfrom
update/stu-1063-empty-screen-becomes-add-site-flow
Dec 1, 2025
Merged

Replace empty screen with add site flow and rename it to NoStudioSites#2149
sejas merged 20 commits intotrunkfrom
update/stu-1063-empty-screen-becomes-add-site-flow

Conversation

@sejas
Copy link
Member

@sejas sejas commented Nov 28, 2025

Related issues

Proposed Changes

  • Remove the empty screen and replace it with add site options

Testing Instructions

  • Remove all your sites from Studio
  • Observe the new screen
  • Continue the flow to create any of the sites
  • Confirm the site was correctly created
Before After
Screenshot 2025-11-27 at 11 27 50 Screenshot 2025-11-28 at 00 21 26

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Nov 28, 2025
@sejas sejas mentioned this pull request Nov 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

📊 Performance Test Results

Comparing 10fa31e vs trunk

site-editor

Metric trunk 10fa31e Diff Change
load 5265.00 ms 7670.00 ms +2405.00 ms 🔴 45.7%

site-startup

Metric trunk 10fa31e Diff Change
siteCreation 14179.00 ms 14227.00 ms +48.00 ms 🔴 0.3%
siteStartup 5974.00 ms 5981.00 ms +7.00 ms 🔴 0.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Copy link
Contributor

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sejas for working on this. I have tested this found couple of issues.

The whats new model appeared

As soon as open Studio, the model appeared. I found bit odd to see that but might not be related this PR. Perhaps, we should add checks to prevent this model appearing on other screens.

Image

The actions were not clickable

I could see the replaced "Add new site" screen on empty state but none of the links/buttons were clickable. I think it has to do something with making window movable by moving it.

CleanShot.2025-11-28.at.10.31.22.mp4

@sejas sejas marked this pull request as draft November 28, 2025 11:25
@sejas sejas requested a review from gavande1 November 28, 2025 12:13
@sejas sejas marked this pull request as ready for review November 28, 2025 12:13
@sejas
Copy link
Member Author

sejas commented Nov 28, 2025

@gavande1 , thanks for the early review. Could you take another look.

The whats new model appeared

I created a new issue STU-1066 so any decision won't block from merging this PR.

The actions were not clickable

This is fixed! Could you test it again?

@sejas sejas requested review from a team and nightnei November 28, 2025 14:24
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sejas, this streamlines the flow to create a site by using the different options. I have tested it, and it works as expected, code changes also LGTM! :shipit:

Image

P.S. I agree with the comment in the linked task about displaying the top bar, which can be helpful if the user has logged in in a previous step. But that is something that can be discussed for a follow-up

Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable then the Add site button in the topbar menu when this screen for adding a site is showing since it does nothing in that case?

Image

Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good 👍 , I just have one minor suggestion about disabling the Add site button in the top navigation

@sejas
Copy link
Member Author

sejas commented Dec 1, 2025

The changes look good 👍 , I just have one minor suggestion about disabling the Add site button in the top navigation

I created an issue to tackle that as a follow-up. STU-1068

@sejas sejas mentioned this pull request Dec 1, 2025
1 task
@sejas sejas changed the title Replace empty screen with add site flow Replace empty screen with add site flow and rename it to NoStudioSites Dec 1, 2025
@sejas sejas merged commit 4c2ce11 into trunk Dec 1, 2025
7 of 10 checks passed
@sejas sejas deleted the update/stu-1063-empty-screen-becomes-add-site-flow branch December 1, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants