Skip to content

Remove streamlineOnboarding feature flag#2171

Merged
sejas merged 4 commits intotrunkfrom
remove/stu-1067-streamline-onboarding-feature-flag
Dec 3, 2025
Merged

Remove streamlineOnboarding feature flag#2171
sejas merged 4 commits intotrunkfrom
remove/stu-1067-streamline-onboarding-feature-flag

Conversation

@sejas
Copy link
Member

@sejas sejas commented Dec 2, 2025

Related issues

Proposed Changes

  • Remove streamlineOnboarding feature flag
  • It also removes the Publish and Pull site buttons in favor of always displaying the connect site button.

Testing Instructions

  • Run npm start
  • Create a site
  • Go to the sync tab
  • Observe that the connect a site button is visible
  • Also observe that the Publish site button next to the start button is present
Screenshot 2025-12-02 at 17 41 43

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Dec 2, 2025
@sejas sejas requested a review from a team December 2, 2025 17:42
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

📊 Performance Test Results

Comparing ef9f8a0 vs trunk

site-editor

Metric trunk ef9f8a0 Diff Change
load 7289.00 ms 10620.00 ms +3331.00 ms 🔴 45.7%

site-startup

Metric trunk ef9f8a0 Diff Change
siteCreation 13206.00 ms 13171.00 ms -35.00 ms 🟢 -0.3%
siteStartup 5973.00 ms 5922.00 ms -51.00 ms 🟢 -0.9%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me although I see some unit tests are failing so might need to be fixed 👍

Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sejas, I have tested it, and it works as expected. I don't see the feature flag and the buttons anymore. Also, the connect site button works as expected. LGTM! :shipit:

Connected site Non-connected site
Image Image

@sejas sejas merged commit 4e84ac2 into trunk Dec 3, 2025
8 of 9 checks passed
@sejas sejas deleted the remove/stu-1067-streamline-onboarding-feature-flag branch December 3, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants