Fix: update latestCliPid after restart in set-* CLI commands#2285
Merged
bcotrim merged 1 commit intodev/studio-cli-i2from Dec 18, 2025
Conversation
fredrikekelund
approved these changes
Dec 18, 2025
Contributor
fredrikekelund
left a comment
fredrikekelund
left a comment
There was a problem hiding this comment.
Based on just reviewing the code, this LGTM 👍
Contributor
|
Let's change the base branch to |
bcotrim
deleted the
stu-1153-studio-set-cli-commands-should-update-latestclipid-after
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
set-domain,set-https,set-php-version, andset-wp-versionCLI commands to callupdateSiteLatestCliPid()after restarting a siteupdateSiteLatestCliPidis called with correct site ID and PID when restartingupdateSiteLatestCliPidis NOT called when site is stopped (no restart needed)Testing Instructions
npm run cli:buildstudio site start --path ~/Studio/mysite --skip-browserstudio site list→ 🟢 Onlinestudio site set-php-version 8.4 --path ~/Studio/mysitestudio site list→ should show 🟢 Online (was 🔴 Offline before fix)npm test -- cli/commands/site/tests/set-php-version.test.ts cli/commands/site/tests/set-domain.test.ts cli/commands/site/tests/set-https.test.ts cli/commands/site/tests/set-wp-version.test.tsPre-merge Checklist