CLI: Only ask for admin permissions once when changing domain#2315
Merged
sejas merged 2 commits intodev/studio-cli-i2from Dec 30, 2025
Merged
Conversation
nightnei
approved these changes
Dec 29, 2025
Contributor
nightnei
left a comment
There was a problem hiding this comment.
LGTM and works as expected 👍
sejas
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issues
Proposed Changes
updateDomainInHosts()function tocli/lib/hosts-file.tsthat handles removing the old domain and adding the new domain in a single hosts file write operation (single admin privilege request)skipHostsUpdateoption tosetupCustomDomain()incli/lib/site-utils.tsto avoid duplicate hosts file updatescli/commands/site/set-domain.tsto use the new combined operationTesting Instructions
studio site set-domain test.local --path <site-path>/etc/hostsstudio site set-domain test2.local --path <site-path>to change the domaintest.localis removed andtest2.localis added to/etc/hostsnpm test -- cli/commands/site/tests/set-domain.test.tsPre-merge Checklist