Use CLI site set command to edit site details from Studio by bcotrim · Pull Request #2360 · Automattic/studio

bcotrim · 2026-01-07T17:32:04Z

Related issues

Fixes STU-1149

Proposed Changes

Add cli-site-editor.ts module to invoke the CLI's studio site set command
Update IPC handler updateSite() to delegate to CLI for site changes (domain, HTTPS, PHP version, WP version)
Simplify edit-site-details.tsx - UI now just calls updateSite() and lets CLI handle restart logic
Simplify site-server.ts updateSiteDetails() since CLI handles hosts file, SSL certs, and WP updates
Create shared utility siteNeedsRestart() in common/lib/ so CLI and Studio UI share the same restart logic

Testing Instructions

Create a site in Studio
Start the site
Open Edit Site modal and change:
- Site name (no restart needed)
- PHP version (should restart)
- WordPress version (should restart and update WP)
- Add custom domain (should restart)
- Enable HTTPS (should restart)
Verify each change works correctly and server restarts when needed
Test editing while site is stopped (should update without restart)

Pre-merge Checklist

Have you checked for TypeScript, React or other console errors?

fredrikekelund

LGTM 👍 Sensible and manageable diff. Nice work!

fredrikekelund · 2026-01-09T13:31:09Z

cli/commands/site/set.ts

 					const loggerError = new LoggerError( __( 'Failed to configure site' ), error );
 					logger.reportError( loggerError );
 				}
+				process.exit( 1 );


Nice catch 👍

fredrikekelund · 2026-01-09T13:33:46Z

cli/lib/wordpress-server-manager.ts

+		processEventHandler = ( event: unknown ) => {
+			const result = pm2ProcessEventSchema.safeParse( event );
+			if ( ! result.success ) {
+				return;
+			}
+
+			if ( result.data.process.name === processName && result.data.event === 'exit' ) {
+				reject( new Error( 'WordPress server process exited unexpectedly' ) );
+			}
+		};


This seems sensible. Out of curiosity, did you add this because of something related to the core purpose of this PR, or was it just something that happened to come up here?

This came up during testing this PR. When changing WP version to an incompatible one (e.g., 6.4.7 with Twenty Twenty-Five theme which requires WP 6.5+), the CLI would hang forever instead of reporting the error.

fredrikekelund · 2026-01-09T13:42:58Z

src/ipc-handlers.ts

@@ -347,23 +348,69 @@ export async function createSite(

 export async function updateSite(


Aside from being exposed as an IPC function, this function is also called in from multiple places in this file. It seems like the old purpose was to:

Write changes to the appdata file.

Update the SiteServer instance itself (which might have been entirely redundant, given that we pass SiteServer.details to this function already).

I'm curious if we really need to keep calling this function from startServer, stopServer, etc..?

Good question, I think it deserves a closer look. I added a note on STU-1193 and will tackle it in that PR if you agree.

fredrikekelund · 2026-01-09T13:48:30Z

cli/wordpress-server-child.ts

+	// Check for WordPress critical error in HTML output
+	const wpDieMatch = message.match( /<div class="wp-die-message"[^>]*>([\s\S]*?)<\/div>/ );
+	if ( wpDieMatch ) {
+		// Extract text from HTML, removing tags
+		const htmlContent = wpDieMatch[ 1 ];
+		const textContent = htmlContent
+			.replace( /<[^>]+>/g, ' ' )
+			.replace( /\s+/g, ' ' )
+			.trim();
+		if ( textContent ) {
+			return `WordPress error: ${ textContent }`;
+		}
+	}
+
+	// Check for PHP fatal error pattern
+	const fatalMatch = message.match( /PHP Fatal error:\s*(.+?)(?:\sin\s|$)/i );
+	if ( fatalMatch ) {
+		return `PHP Fatal error: ${ fatalMatch[ 1 ].trim() }`;
+	}


I'm curious what these two conditions are based on. XDebug errors?

It also related to the WordPress issue I came across during testing.
I just tried to clean the errors a bit so it's more UI friendly.

fredrikekelund · 2026-01-09T13:49:15Z

src/modules/site-settings/edit-site-details.tsx

It's a small thing, but I still love the changes to this file. This is the kind of business logic consolidation that I think will do Studio a lot of good 👍

fredrikekelund · 2026-01-09T13:54:39Z

src/site-server.ts

+			tlsKey: site.tlsKey,
+			tlsCert: site.tlsCert,


Note for the future: we don't need to load these details in the Studio app anymore

fredrikekelund · 2026-01-09T13:55:18Z

src/modules/cli/lib/cli-site-editor.ts

+		} );
+
+		emitter.on( 'success', () => {
+			console.log( `[CLI Site Editor] Command completed successfully` );


Do we need this?

bcotrim self-assigned this Jan 7, 2026

bcotrim requested a review from fredrikekelund January 7, 2026 17:33

bcotrim added 2 commits January 8, 2026 10:49

use studio site set to edit site from studio

bad0ff1

add xdebug and adjust update errors

52dbfca

bcotrim force-pushed the stu-1149-check-edit-site-details-from-studio branch from 5ad33ba to 52dbfca Compare January 8, 2026 15:54

code cleanup

e7865ab

bcotrim marked this pull request as ready for review January 8, 2026 17:45

trigger tests

df1d3d2

fredrikekelund approved these changes Jan 9, 2026

View reviewed changes

remove debug console.log

71e6aa4

bcotrim merged commit f1f0731 into dev/studio-cli-i2 Jan 9, 2026
3 of 4 checks passed

bcotrim deleted the stu-1149-check-edit-site-details-from-studio branch January 9, 2026 16:26

fredrikekelund mentioned this pull request Jan 12, 2026

Studio CLI: Fix Windows E2E tests #2299

Merged

1 task

fredrikekelund mentioned this pull request Jan 22, 2026

Fix regression where themeDetails are not persisted to appdata file #2447

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use CLI site set command to edit site details from Studio#2360

Use CLI site set command to edit site details from Studio#2360
bcotrim merged 5 commits intodev/studio-cli-i2from
stu-1149-check-edit-site-details-from-studio

bcotrim commented Jan 7, 2026 •

edited

Loading

Uh oh!

fredrikekelund left a comment

Uh oh!

fredrikekelund Jan 9, 2026

Uh oh!

fredrikekelund Jan 9, 2026

Uh oh!

bcotrim Jan 9, 2026

Uh oh!

fredrikekelund Jan 9, 2026

Uh oh!

bcotrim Jan 9, 2026

Uh oh!

fredrikekelund Jan 9, 2026

Uh oh!

bcotrim Jan 9, 2026

Uh oh!

fredrikekelund Jan 9, 2026

Uh oh!

fredrikekelund Jan 9, 2026

Uh oh!

fredrikekelund Jan 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -347,23 +348,69 @@ export async function createSite(

		export async function updateSite(

Conversation

bcotrim commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues

Proposed Changes

Testing Instructions

Pre-merge Checklist

Uh oh!

fredrikekelund left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bcotrim commented Jan 7, 2026 •

edited

Loading