Miscellaneous translation tweaks#2388
Conversation
| const port = await portFinder.getOpenPort(); | ||
| logger.reportSuccess( __( 'Port assigned: ' ) + port ); | ||
| // translators: %d is the port number | ||
| logger.reportSuccess( sprintf( __( 'Port assigned: %d' ), port ) ); |
| </div> | ||
| </SettingsRow> | ||
| <SettingsRow label={ __( 'Local URL' ) }> | ||
| <SettingsRow label={ __( 'Site URL' ) }> |
There was a problem hiding this comment.
At first, I thought Local URL would be better in this particular context, but after looking at the Settings tab, it's clear when we say Site URL just after Site name there.
| __( 'Enable the %s command in the terminal.' ), | ||
| '<code>studio</code>' | ||
| __( 'Enable the <code>%s</code> command in the terminal.' ), | ||
| 'studio' |
There was a problem hiding this comment.
Do we plan to substitute other command names?
There was a problem hiding this comment.
You mean if we plan to substitute studio for something else? No. Still, I think it adds robustness to keep the command name outside the translation string, as it's not subject to translation.
There was a problem hiding this comment.
Yes, I meant if we are going to make it dynamic and support different values.
|
Thanks for addressing those, and for improving other areas, too. Looks much more consistent now. |
katinthehatsite
left a comment
katinthehatsite
left a comment
There was a problem hiding this comment.
The changes look good to me 👍
| throw new LoggerError( | ||
| __( | ||
| 'SQLite integration files not found. Please ensure Studio Desktop is installed and has been run at least once.' | ||
| 'SQLite integration files not found. Please ensure Studio is installed and has been run at least once.' |
There was a problem hiding this comment.
Not sure if the name should be WordPress Studio Desktop vs. Studio since it is how we generally refer to the app. Not a big deal though, can leave as is 👍
There was a problem hiding this comment.
It's good to refer to Studio as a short name in the interface, docs, etc.
3 participants
Related issues
Proposed Changes
As noted by @wojtekn, the newfangled CLI code has some inconsistencies in the translation strings. This PR addresses the following things:
Testing Instructions
Code review should suffice
Pre-merge Checklist