Fix Typescript errors and clean up TS configs#2685
Merged
fredrikekelund merged 19 commits intotrunkfrom Mar 9, 2026
Merged
Conversation
fredrikekelund
commented
Mar 3, 2026
Collaborator
📊 Performance Test ResultsComparing 8ac4a6f vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
sejas
approved these changes
Mar 9, 2026
Member
sejas
left a comment
There was a problem hiding this comment.
Changes look good. I tested it the app by starting a site and logging in. I also tried executing the new CLI command npm run typecheck.
Contributor
Author
|
Thanks for the review, @sejas 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes STU-1373
Proposed Changes
We currently have a few TS errors in our code. This PR addresses that with the following changes:
typechecknpm script.AGENTS.mdto tell agents to do type checking."*": [ "node_modules/*" ]resolvers intsconfig.jsonfiles. This means it's no longer possible to import any code fromnode_modulesfiles. Instead, we use regular module resolution to import available modules.use-update-button-tooltip.ts) to make this work.@types/globandwpcomto prevent TS from complaining.yargsdependency during build. This is a different way of tackling the issue raised in Fix Studio CLI yargs locale strings displaying in English #2609. I had to address this because yarg'supdateStringsfunction didn't play nice with the type definitions fromapps/cli/lib/i18n.ts. By not bundling the yargs code, we sidestep the problem altogether.Testing Instructions
CI should pass.
Pre-merge Checklist