Skip to content

Conversation

@joaopamaral
Copy link

@joaopamaral joaopamaral commented Sep 28, 2024

Description of change

Github removed the X-RateLimit-Remaining from the releases endpoint causing the exception even returning status 200. We can let the backoff deal with the cases with no rate limit remaining.

  • Tested locally with meltano
meltano el tap-github target-parquet --select releases

Manual QA steps

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@joaopamaral joaopamaral changed the title Remove exception if no X-RateLimit-Remaining is not found in the he… Remove the exception if no X-RateLimit-Remaining is not found in the header Sep 28, 2024
@joaopamaral joaopamaral changed the title Remove the exception if no X-RateLimit-Remaining is not found in the header Remove the exception if no X-RateLimit-Remaining is found in the header Sep 28, 2024
@joaopamaral joaopamaral requested a review from a team September 28, 2024 09:23
@joaopamaral joaopamaral merged commit 5a75eb9 into master Sep 28, 2024
@joaopamaral
Copy link
Author

Other users are facing the same issue:
https://github.com/orgs/community/discussions/140079

And Github API docs still indicate the rate limit remains in the response header. https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#checking-the-status-of-your-rate-limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants