Cancelling uploadMedia task should cancel underlying HTTP request#794
Merged
Cancelling uploadMedia task should cancel underlying HTTP request#794
Conversation
oguzkocer
approved these changes
Jul 7, 2025
Contributor
oguzkocer
left a comment
oguzkocer
left a comment
There was a problem hiding this comment.
I think we'll have to update the Kotlin wrapper to handle the new error type. I am surprised it didn't cause a failure. However, we can merge this as is and I can take a look at that separately.
Contributor
We are not mapping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two main changes in this PR:
RequestExecutionErrorReason::CancellationError. Currently, cancelling an HTTP API call results inRequestExecutionErrorReason::GenericError { message: "cancelled" }, which is not specific enough. Adding aCancellationErrorwould help developers to distinguish errors due to the user cancelling operations from other unexpected errors.try await uploadTask.valuecall would handle cancellation, but turns out it does not. I have addressed this issue in this PR and added a couple of unit tests to cover it.