Merged
Conversation
crazytonyli
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #92.
Follows the design of Filter users to implement field based filtering for
/pluginsforlist&retrievevariants. Similar to/users,create&updatevariants have a separate issue #93.I think we have several refactoring opportunities in this PR, but I intentionally kept the PR simple and similar to the
/usersimplementation. I need these PRs to be reviewed and merged quickly and adding refactoring into a PR can end up delaying things, so I'll separate it into its own PR.To Test
make test-server && make dump-mysql && make backup-wp-content-pluginscargo test --test '*' -- --nocapture --test-threads 1