Skip to content

Bulk invite users, make sure ass_scan_ds test fails on error#243

Open
lvgelder wants to merge 3 commits intomasterfrom
186446460_bulk_invite_users
Open

Bulk invite users, make sure ass_scan_ds test fails on error#243
lvgelder wants to merge 3 commits intomasterfrom
186446460_bulk_invite_users

Conversation

@lvgelder
Copy link

No description provided.

@lvgelder lvgelder force-pushed the 186446460_bulk_invite_users branch from 15348e1 to 82c56b6 Compare November 20, 2023 14:21
Copy link
Contributor

@dbechrd dbechrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing associate_scan_dataset.ts in this commit? Seems unrelated. Did you notice a bug while working on bulk user invites, or is that a leftover diff that slipped in accidentally?

@lvgelder
Copy link
Author

Why are we changing associate_scan_dataset.ts in this commit? Seems unrelated. Did you notice a bug while working on bulk user invites, or is that a leftover diff that slipped in accidentally?

I noticed a bug while working on it. It can be a separate commit.

@ksgerst
Copy link
Contributor

ksgerst commented Nov 21, 2023

@lvgelder - I recently added this similar method: 4e63414

As I mentioned in standup, I found some weirdness when trying to write a test using FormData and Blob without a browser. I did some research and found the below stackoverflow link, but we do need to come up with a testing strategy for these in this library.
https://stackoverflow.com/questions/63576988/how-to-use-formdata-in-node-js-without-browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants