Skip to content

Merge branch 'axon-5.1.x'#4590

Merged
smcvb merged 1 commit into
mainfrom
merge/axon-5.1.x-to-main
May 20, 2026
Merged

Merge branch 'axon-5.1.x'#4590
smcvb merged 1 commit into
mainfrom
merge/axon-5.1.x-to-main

Conversation

@hjohn
Copy link
Copy Markdown
Contributor

@hjohn hjohn commented May 19, 2026

Merge axon-5.1.x into main, resolving conflicts:

@hjohn hjohn requested a review from a team as a code owner May 19, 2026 13:52
@hjohn hjohn requested review from jangalinski, laura-devriendt-lemon and zambrovski and removed request for a team May 19, 2026 13:52
@MateuszNaKodach
Copy link
Copy Markdown
Contributor

I would remove the axon-5/api-changes.md to do not duplicate the content. Just keep the api-changes files as a source of truth and the only thing to maintain.

@hjohn hjohn force-pushed the merge/axon-5.1.x-to-main branch 2 times, most recently from 56d0d2c to b034625 Compare May 19, 2026 14:14
Merge axon-5.1.x into main, resolving conflicts:
- MergeTask.java: take axon-5.1.x version removing redundant releaseClaim (bug fix #4583)
- axon-5/api-changes.md: keep main version (file was split into per-topic files on main)
@hjohn hjohn force-pushed the merge/axon-5.1.x-to-main branch from b034625 to 2c48431 Compare May 19, 2026 14:35
@hjohn
Copy link
Copy Markdown
Contributor Author

hjohn commented May 19, 2026

I would remove the axon-5/api-changes.md to do not duplicate the content. Just keep the api-changes files as a source of truth and the only thing to maintain.

I removed the old file, and checked what changes still were in there and merged those with the split version (only some package renames).

@sonarqubecloud
Copy link
Copy Markdown

@smcvb smcvb added Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Type: Port Use to refer to an issue or pull request that ports logic from one branch to another. labels May 19, 2026
@smcvb smcvb added this to the Release 5.2.0 milestone May 19, 2026
Copy link
Copy Markdown
Contributor

@MateuszNaKodach MateuszNaKodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I focused on my own changes, so from the PR:
#4583
This looks good. If you're sure about others - feel free to merge :)

Copy link
Copy Markdown
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit e1fbabd into main May 20, 2026
11 checks passed
@smcvb smcvb deleted the merge/axon-5.1.x-to-main branch May 20, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Type: Port Use to refer to an issue or pull request that ports logic from one branch to another.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PooledStreamingEventProcessor.splitSegment() leaves token store in inconsistent state with JdbcTokenStore (AF 5.1.0)

3 participants