Properly handle multiple rename (delete) events in inotify buffer#172
Merged
ianhattendorf merged 1 commit intoAxosoft:masterfrom Nov 28, 2022
Merged
Conversation
Contributed on behalf of ST Microelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Contributor
Author
|
@julianmesa-gitkraken what's the protocol for getting PR's merged? |
Contributor
I need to reproduce and test it, I will try to do it today |
Contributor
Author
|
Fantastic, thanks. |
julianmesa-gitkraken
approved these changes
Nov 24, 2022
Contributor
julianmesa-gitkraken
left a comment
julianmesa-gitkraken
left a comment
There was a problem hiding this comment.
After testing, I agree with the solution.
We are moving to trash and removeDirectory should be called when isDirectoryRemoval only.
Contributor
|
Thanks! |
Contributor
Author
|
@ianhattendorf can you give an ETA when a new release will go out? |
Contributor
Contributor
Author
|
Thx, it's great to have an approximate ETA (and more fixes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supposed to fix #171
Contributed on behalf of ST Microelectronics
Signed-off-by: Thomas Mäder t.s.maeder@gmail.com