Fix bugs in branch v6.0.0-beta.2#582
Fix bugs in branch v6.0.0-beta.2#582moarychan merged 1 commit intoAzure-Samples:spring-cloud-azure-v6.0.0-beta.2from
Conversation
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-security</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
why we need to explicit add this dependency?
anything changed from spring boot 3?
does this work without this spring-secruity-oauth2-core in spring boot 2.x sample?
There was a problem hiding this comment.
It's also a bug in the main branch, which will fix in the next PR.
The class org.springframework.security.oauth2.core.AuthorizationGrantType is referred to com.azure.spring.cloud.autoconfigure.aad.properties.AuthorizationClientProperties#authorizationGrantType, this sample scenario will not depend on Security OAuth2 Client dependencies, it's only to demo the com.azure.spring.cloud.autoconfigure.aad.filter.AadAuthenticationFilter.
There was a problem hiding this comment.
I remember per our discussion, the dependency should be the resource server starter, since the application acts as a resource server.
There was a problem hiding this comment.
We should think about how we could improve this. This shouldn't be the best practice.
There was a problem hiding this comment.
Opened an issue: Azure/azure-sdk-for-java#32509
Purpose
spring-security-oauth2-coreto fix classorg.springframework.security.oauth2.core.AuthorizationGrantTypenot foundDoes this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
N/A
N/A
What to Check
Verify that the following are valid
Other Information
N/A