Skip to content

Fix bugs in branch v6.0.0-beta.2#582

Merged
moarychan merged 1 commit intoAzure-Samples:spring-cloud-azure-v6.0.0-beta.2from
moarychan:moary/fix-issues
Dec 8, 2022
Merged

Fix bugs in branch v6.0.0-beta.2#582
moarychan merged 1 commit intoAzure-Samples:spring-cloud-azure-v6.0.0-beta.2from
moarychan:moary/fix-issues

Conversation

@moarychan
Copy link
Contributor

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

N/A

  • Test the code
    N/A

What to Check

Verify that the following are valid

  • ...

Other Information

N/A

<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-security</artifactId>
</dependency>
<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to explicit add this dependency?
anything changed from spring boot 3?
does this work without this spring-secruity-oauth2-core in spring boot 2.x sample?

Copy link
Contributor Author

@moarychan moarychan Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also a bug in the main branch, which will fix in the next PR.
The class org.springframework.security.oauth2.core.AuthorizationGrantType is referred to com.azure.spring.cloud.autoconfigure.aad.properties.AuthorizationClientProperties#authorizationGrantType, this sample scenario will not depend on Security OAuth2 Client dependencies, it's only to demo the com.azure.spring.cloud.autoconfigure.aad.filter.AadAuthenticationFilter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember per our discussion, the dependency should be the resource server starter, since the application acts as a resource server.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about how we could improve this. This shouldn't be the best practice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments