Open
Conversation
bgavrilMS
reviewed
Sep 29, 2025
| @@ -0,0 +1,63 @@ | |||
| # Dependencies | |||
Author
There was a problem hiding this comment.
5-advanced should be named 4-advanced (think this was a Copilot mistake!), I'll get this updated.
bgavrilMS
reviewed
Sep 29, 2025
| .env.production.local | ||
|
|
||
| # Build outputs | ||
| build/ |
There was a problem hiding this comment.
Many of the sub-chapters in chapter 1 do not have readmes.
1-server-side/express-web-app-auth - does it even work? It has 2 sets of controllers, no auth code
1-server-side/express-web-app-deployment - no idea what this is, there doesn't seem to be any auth code
1-server-side/node-console-app - empty
nodejs-call-graph - it's just the web app?
We are missing a web api sample?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request consolidated the ms-identity-node code sample, allowing it to be the single source of truth for identity node samples.
The PR introduces samples from the other following repos - which once merged will be archived: