Skip to content

Fix: Safely handle missing session data on redirect #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ba2slk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Safely handle missing session data on redirect #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions App/auth/AuthProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,12 @@ class AuthProvider {
return next(new Error('Error: response not found'));
}

// Safely handle missing session data and prevent a TypeError by redirecting.
if (!req.session || !req.session.pkceCodes) {
console.error('Session data is missing. PKCE codes could not be retrieved.');
return res.redirect('/');
}

const authCodeRequest = {
...req.session.authCodeRequest,
code: req.body.code,
Expand Down