Initial e2e testing for external auth for ARO HCP. #2376
Conversation
|
Skipping CI for Draft Pull Request. |
|
Please rebase pull request. |
Nanyte25
requested review from
DennisJWheeler,
SudoBrendan,
bennerv,
hbhushan3,
katherinelc321,
kostola,
mbarnes,
mbukatov,
mgahagan73,
mociarain,
oriAdler,
patriksuba,
tony-schndr,
tsatam and
venkateshsredhat
as code owners
|
/test all |
Includes API test, cluster test, and supporting script updates
mbukatov
left a comment
mbukatov
left a comment
There was a problem hiding this comment.
Thank you for working on the tests. QE team will reach out to you to help with setup work so that the test can use existing plumbing code and unified way to pass setup information. Without this, every test will be handling setup slightly differently which will be impossible to run in the CI consistently.
| clientSecret = os.Getenv("AZURE_CLIENT_SECRET") | ||
| tenantID = os.Getenv("AZURE_TENANT_ID") | ||
| scope = os.Getenv("AZURE_SCOPE") // typically "api://<resource-app-id>/.default" | ||
| apiURL = os.Getenv("EXTERNAL_AUTH_TEST_ENDPOINT") // e.g., https://<cluster-api>/api/ping |
There was a problem hiding this comment.
There already is a way to pass these parameters into the test. And for new parameters (like external auth test endpoint), we should get this value from a bicep run output.
There was a problem hiding this comment.
@mociarain Should we be passing these vars using parms bicep file ?
…ads and fixing imageRegistry to enabled.
Nanyte25
requested review from
JameelB,
UlrichSchlueter,
deads2k,
geoberle,
janboll,
jfchevrette,
jharrington22,
jmelis,
jonathan34c,
machi1990,
miguelsorianod,
mmazur,
roivaz,
stevekuznetsov,
weinong and
whober0521
as code owners
|
Please rebase pull request. |
|
@Nanyte25: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I am going to close this out in Favour of #2414 |
ARO-20092
What
Why
Special notes for your reviewer