-
Notifications
You must be signed in to change notification settings - Fork 103
Expand the step-style integration tests to make http frontend testing easier #3662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f29f3e to
0e80430
Compare
0e80430 to
1e56d4b
Compare
1e56d4b to
6245cb8
Compare
mbarnes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot here and I think I'm gonna have to play with this to fully grok it. Fortunately I've got a couple bugs on my plate where I think I can leverage this test framework you've built. I didn't go through 100% of the code in detail, but I think I get the gist of it and it looks good to me.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mbarnes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
This adds the ability to easily test the cosmos DB entries that result from frontend requests. It is a necessary prereq to the data migration in #3651 where the records in cosmos will change.