Skip to content

Conversation

@ehvs
Copy link
Collaborator

@ehvs ehvs commented Jan 5, 2026

Which issue this PR addresses:

The verbosity and noise from

INFO[2026-01-05T17:10:58+01:00]pkg/util/azureclient/roundtripper.go:55 azureclient.loggingRoundTripper() HttpRequestStart                              LOGKIND=outboundRequests [...]"
INFO[2026-01-05T17:10:58+01:00]pkg/util/azureclient/roundtripper.go:60 azureclient.loggingRoundTripper() HttpRequestEnd                                LOGKIND=outboundRequests [...]

What this PR does / why we need it:

  • To facilitate and make easier to debug and analyse meanifgul messages when working on local dev.
  • It makes toggeable to true or false when RP_MODE=development, via flag ARO_ENABLE_OUTBOUND_HTTP_LOGGING=true/false
  • Prod can’t be “accidentally disabled”: outboundHTTPLoggingEnabled() returns true for any RP_MODE != development, ignoring ARO_ENABLE_OUTBOUND_HTTP_LOGGING=false.

Impact

The caveat that i found is that we use the func NewLoggingPolicy() policy.Policy { for other activities that uses RP_MODE=development , like e2e/setup.go and purge.go, will also have the logging disabled unless it overridden with the flag.

Test plan for issue:

  • Running OS_CLUSTER_VERSION="4.16.30" CLUSTER=hevsdev2 go run ./hack/cluster create the output is leaner.
[...]
 MasterVMSizes: ([]string) (len=3 cap=3) {
  (string) (len=15) "Standard_D8s_v5",
  (string) (len=15) "Standard_D8s_v4",
  (string) (len=15) "Standard_D8s_v3"
 },
 WorkerVMSizes: ([]string) (len=4 cap=4) {
  (string) (len=15) "Standard_D2s_v3",
  (string) (len=15) "Standard_D4s_v5",
  (string) (len=15) "Standard_D4s_v4",
  (string) (len=15) "Standard_D4s_v3"
 }
})
INFO[2026-01-05T16:52:02+01:00]pkg/util/cluster/cluster.go:754 cluster.(*Cluster).Delete() Deleting cluster hevsdev2 in resource group v4-eastus 
INFO[2026-01-05T16:52:02+01:00]pkg/util/cluster/cluster.go:1265 cluster.(*Cluster).deleteRoleAssignments() deleting role assignments                    
INFO[2026-01-05T16:52:05+01:00]pkg/util/cluster/cluster.go:1289 cluster.(*Cluster).deleteRoleAssignments() deleting role assignment 37fa2959-8fe2-4f3f-a895-a3726ceab506 
INFO[2026-01-05T16:52:08+01:00]pkg/util/cluster/cluster.go:1289 cluster.(*Cluster).deleteRoleAssignments() deleting role assignment 56ea839b-a26e-4c25-b3d6-92efe1f3e868 
INFO[2026-01-05T16:52:10+01:00]pkg/util/cluster/cluster.go:1289 cluster.(*Cluster).deleteRoleAssignments() deleting role assignment 669f6610-e529-4332-ac97-6c957d001026 
INFO[2026-01-05T16:52:12+01:00]pkg/util/cluster/cluster.go:1342 cluster.(*Cluster).deleteCluster() deleting cluster hevsdev2                    
INFO[2026-01-05T16:58:21+01:00]pkg/util/cluster/cluster.go:1302 cluster.(*Cluster).deleteWimiRoleAssignments() Skipping deletion of wimi roleassignments    
INFO[2026-01-05T16:58:21+01:00]pkg/util/cluster/cluster.go:850 cluster.(*Cluster).deleteWI() Skipping deletion of workload identity roles 
INFO[2026-01-05T16:58:21+01:00]pkg/util/cluster/cluster.go:1390 cluster.(*Cluster).deleteDeployment() deleting deployment                          
INFO[2026-01-05T16:58:37+01:00]pkg/util/cluster/cluster.go:1400 cluster.(*Cluster).deleteVnetResources() deleting master/worker subnets               
INFO[2026-01-05T16:59:00+01:00]pkg/util/cluster/cluster.go:1411 cluster.(*Cluster).deleteVnetResources() deleting route table                         
INFO[2026-01-05T16:59:04+01:00]pkg/util/cluster/cluster.go:843 cluster.(*Cluster).Delete() Delete completed successfully        

Is there any documentation that needs to be updated for this PR?

Yes. TBD

  • Local Dev Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants