Disable logging outboundHTTPrequests when RP_MODE=development #4536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
The verbosity and noise from
What this PR does / why we need it:
trueorfalsewhenRP_MODE=development, via flagARO_ENABLE_OUTBOUND_HTTP_LOGGING=true/falseRP_MODE != development, ignoringARO_ENABLE_OUTBOUND_HTTP_LOGGING=false.Impact
The caveat that i found is that we use the
func NewLoggingPolicy() policy.Policy {for other activities that usesRP_MODE=development, like e2e/setup.go and purge.go, will also have the logging disabled unless it overridden with the flag.Test plan for issue:
OS_CLUSTER_VERSION="4.16.30" CLUSTER=hevsdev2 go run ./hack/cluster createthe output is leaner.Is there any documentation that needs to be updated for this PR?
Yes. TBD