Add support for custom sort order#121
Merged
daltondhcp merged 3 commits intoAzure:mainfrom Sep 7, 2022
Merged
Conversation
5 tasks
Contributor
|
I have tested the functionality and it works as expected - awesome job! 😄 |
Collaborator
Author
|
Sure, I can put the code in a scripts folder. How about .pipelines/.script/customSortOrder.ps1? Or maybe have a generic location for both GitHub and ADO? Maybe .scripts/customSortOrder.ps1? |
Contributor
Sounds like a good plan to me! |
Collaborator
Author
|
Sorry for the delay, should be working now. |
daltondhcp
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Add option to configure in which order templates will be deployed by adding a conditional step between Diff and Validate/Deploy.
I am a bit uncertain on if the variable
AZOPS_CUSTOM_SORT_ORDERshould be put into the credentials variable group or if a new group should be created. If a new group should be created, I am uncertain of what to name it.I have considered the following names:
I do not think it should be named anything related to settings to avoid confusion with settings.json
This PR fixes/adds/changes/removes
Breaking Changes
For Azure DevOps only: Requires creation of variable group
azopsas well as granting pipelines access to that group.Testing Evidence
CustomSorting step sorts files in diff.txt

Deploy step uses parameter -CustomSortOrder and picks up on the order in diff.txt

As part of this Pull Request I have
mainbranchFixes Azure/AzOps#592