Skip to content

Cleanup of New-AzOpsDeployment and CustomSortOrder feature for Invoke-AzOpsPush#632

Merged
daltondhcp merged 4 commits intoAzure:mainfrom
daltondhcp:deploycleanup
May 20, 2022
Merged

Cleanup of New-AzOpsDeployment and CustomSortOrder feature for Invoke-AzOpsPush#632
daltondhcp merged 4 commits intoAzure:mainfrom
daltondhcp:deploycleanup

Conversation

@daltondhcp
Copy link
Contributor

Overview/Summary

  • Cleanup/optimization of New-AzOpsDeployment to reduce duplication of code and improve maintainability.
  • Added -CustomSortOrder switch in Invoke-AzOpsPush to enable scenarios described in Add option to specify deployment order #592. It will still sort the deploymentlist by default.
  • Added simple integration test scenarios for bicep deployments

Breaking Changes

N/A

Testing Evidence

  • Validated Invoke-AzOpsPush/New-AzOpsDeployment functionality at all relevant scopes (Tenant/ManagementGroup/Subscription/ResourceGroup) in test environment
    • Test cases will also cover all changes in New-AzOpsDeployment
  • -CustomSortOrder switch validated as per below screenshots - (YES, I have a high res monitor)
    DeploymentList:
    image
    Without -CustomSortOrder:
    image
    With -CustomSortOrder:
    image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@daltondhcp daltondhcp requested a review from a team as a code owner May 19, 2022 11:32
@daltondhcp daltondhcp added this to the Release - v1.8.0 milestone May 19, 2022
@daltondhcp daltondhcp added enhancement New feature or request area/powershell labels May 19, 2022
@SimonWahlin
Copy link
Collaborator

Nice with a CustomSortOrder parameter, this will be very useful.

Also, really appreciate the cleanup! 👍👌

@daltondhcp daltondhcp requested review from a team as code owners May 19, 2022 15:30
@daltondhcp daltondhcp temporarily deployed to test May 19, 2022 15:30 Inactive
Copy link
Member

@Jefajers Jefajers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🥇

@daltondhcp daltondhcp merged commit 0a3419a into Azure:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/powershell enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants