Skip to content

Digital Shadows solution#4026

Merged
NikTripathi merged 45 commits intoAzure:masterfrom
parag-metron:Digital-Shadows-connector
Jul 22, 2022
Merged

Digital Shadows solution#4026
NikTripathi merged 45 commits intoAzure:masterfrom
parag-metron:Digital-Shadows-connector

Conversation

@shikhin-metron
Copy link
Contributor

@shikhin-metron shikhin-metron commented Jan 28, 2022


Change(s):

  • Initial PR
  • Added solution by Digital Shadows for Azure Sentinel
  • Contains Analytic rule yaml file, Connector Azure function, Playbook JSON file, and Workbook JSON file.

Reason for Change(s):

  • Initial PR

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@shikhin-metron shikhin-metron marked this pull request as draft January 28, 2022 09:30
@shikhin-metron shikhin-metron marked this pull request as ready for review January 31, 2022 11:24
@shainw shainw added the Solution Solution specialty review needed label Feb 2, 2022
@v-sabiraj
Copy link
Contributor

v-sabiraj commented Feb 24, 2022

@shikhin-metron , please fix the typo Github to GitHub and deployement to deployment in readme.md file, thanks

@v-sabiraj
Copy link
Contributor

@shikhin-metron, can you please update the README file for playbooks. Thanks.

comment_data = self.DS_obj.get_triage_comments(triage_item['id'])

for comment in comment_data:
if not comment['content']:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if not comment['content']:
if not 'content' in comment:

the current version of this will error, rather than fail, if the 'content' key is missing from the comment object.

Comment on lines 89 to 94
azure_obj['comments'].append({
'user_name': comment['user']['name'],
'content': comment['content'],
'id': comment['id'],
'created': comment['created']
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

['user'] can sometimes be null.

Suggested change
azure_obj['comments'].append({
'user_name': comment['user']['name'],
'content': comment['content'],
'id': comment['id'],
'created': comment['created']
})
uname = comment['user']['name'] if comment['user'] and 'name' in comment['user'] else None
azure_obj['comments'].append({
'user_name': uname,
'content': comment['content'],
'id': comment['id'],
'created': comment['created']
})

@v-sabiraj
Copy link
Contributor

Hey @devikamehra, can you please check and approve the changes, thanks.

devikamehra
devikamehra previously approved these changes Jul 11, 2022
@ds-jdcockrill
Copy link

@v-sabiraj - are there any further approvals required or can this PR be merged?
@anki-narravula requested changes some time ago, but we also fixed the requested issues a long time ago as well so can you please tell us what is left before this PR merges?

@v-sabiraj
Copy link
Contributor

Hey @shikhin-metron, the recent changes done for code change in python files are not implemented in zip folder, please check and update the zip, thanks.
image

@v-sabiraj
Copy link
Contributor

@shikhin-metron, please move the Solution_DigitalShadowsSearchlight.json file by creating a folder named as data inside solution folder, please refer this solution for reference.

@NikTripathi NikTripathi dismissed anki-narravula’s stale review July 22, 2022 07:20

Devika already approved playbooks.

@NikTripathi NikTripathi merged commit f43c535 into Azure:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Connector Connector specialty review needed Detection Detection specialty review needed Playbook Playbook specialty review needed Solution Solution specialty review needed Workbook Workbook specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.