Conversation
…zure-Sentinel into Digital-Shadows-connector
|
@shikhin-metron , please fix the typo Github to GitHub and deployement to deployment in readme.md file, thanks |
|
@shikhin-metron, can you please update the README file for playbooks. Thanks. |
...ows/Data Connectors/Digital Shadows/DigitalShadowsConnectorAzureFunction/state_serializer.py
Fixed
Show fixed
Hide fixed
...ows/Data Connectors/Digital Shadows/DigitalShadowsConnectorAzureFunction/state_serializer.py
Fixed
Show fixed
Hide fixed
...gital Shadows/Data Connectors/Digital Shadows/DigitalShadowsConnectorAzureFunction/AS_api.py
Fixed
Show fixed
Hide fixed
...gital Shadows/Data Connectors/Digital Shadows/DigitalShadowsConnectorAzureFunction/DS_api.py
Fixed
Show fixed
Hide fixed
| comment_data = self.DS_obj.get_triage_comments(triage_item['id']) | ||
|
|
||
| for comment in comment_data: | ||
| if not comment['content']: |
There was a problem hiding this comment.
| if not comment['content']: | |
| if not 'content' in comment: |
the current version of this will error, rather than fail, if the 'content' key is missing from the comment object.
| azure_obj['comments'].append({ | ||
| 'user_name': comment['user']['name'], | ||
| 'content': comment['content'], | ||
| 'id': comment['id'], | ||
| 'created': comment['created'] | ||
| }) |
There was a problem hiding this comment.
['user'] can sometimes be null.
| azure_obj['comments'].append({ | |
| 'user_name': comment['user']['name'], | |
| 'content': comment['content'], | |
| 'id': comment['id'], | |
| 'created': comment['created'] | |
| }) | |
| uname = comment['user']['name'] if comment['user'] and 'name' in comment['user'] else None | |
| azure_obj['comments'].append({ | |
| 'user_name': uname, | |
| 'content': comment['content'], | |
| 'id': comment['id'], | |
| 'created': comment['created'] | |
| }) |
|
Hey @devikamehra, can you please check and approve the changes, thanks. |
|
@v-sabiraj - are there any further approvals required or can this PR be merged? |
|
Hey @shikhin-metron, the recent changes done for code change in python files are not implemented in zip folder, please check and update the zip, thanks. |
|
@shikhin-metron, please move the Solution_DigitalShadowsSearchlight.json file by creating a folder named as data inside solution folder, please refer this solution for reference. |
Devika already approved playbooks.

Change(s):
Reason for Change(s):
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: