Update the bash command execution to specify set -e when executing.
#155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarcella
changed the title
set -e when executing commands.set -e when executing.
Member
Author
|
Related to #125 |
vmarcella
added a commit
that referenced
this pull request
May 21, 2024
…#155) This PR allows for the innovation engine to correctly terminate a code block after any command inside of it has failed. Previously the innovation engine would rely on the last command in the code block being executed to check for & report failure which meant that code blocks which executed multiple commands would not fail if any command other than the last one had an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for the innovation engine to correctly terminate a code block after any command inside of it has failed. Previously the innovation engine would rely on the last command in the code block being executed to check for & report failure which meant that code blocks which executed multiple commands would not fail if any command other than the last one had an error.