-
Notifications
You must be signed in to change notification settings - Fork 178
Azure DDoS protection #107 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b399a1e
Add ddosSwitch parameter to enable the deployment of a Azure DDoS pro…
73fc171
Relocate the property (type) at the top of resource definition
25d6d68
Add documentation about ddosSwith parameter in Parameters.md.
eaa6e08
Add more information about how to activate the Azure DDoS protection …
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| { | ||
| "$schema": "http://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "parameters": { | ||
| "moodleCommon": { | ||
| "metadata": { | ||
| "description": "Common Moodle values" | ||
| }, | ||
| "type": "object" | ||
| }, | ||
| "vnetName": { | ||
| "metadata": { | ||
| "description": "The name of the vnet to which the DDoS protection plan shoud be associated" | ||
| }, | ||
| "type": "string" | ||
| }, | ||
| "vNetAddressSpace": { | ||
| "metadata": { | ||
| "description": "The vNet Address Space to which the DDoS protection plan shoud be associated" | ||
| }, | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/ddosProtectionPlans", | ||
| "apiVersion": "2018-02-01", | ||
| "condition": "[parameters('moodleCommon').ddosSwitch]", | ||
| "location": "[resourceGroup().location]", | ||
| "name": "[parameters('moodleCommon').ddosPlanName]" | ||
| }, | ||
| { | ||
| "type": "Microsoft.Network/virtualNetworks", | ||
| "apiVersion": "2018-02-01", | ||
| "dependsOn": [ | ||
| "[resourceId('Microsoft.Network/ddosProtectionPlans', parameters('moodleCommon').ddosPlanName)]" | ||
| ], | ||
| "location": "[resourceGroup().location]", | ||
| "name": "[parameters('vnetName')]", | ||
| "properties": { | ||
| "addressSpace": { | ||
| "addressPrefixes": [ | ||
| "[parameters('vNetAddressSpace')]" | ||
| ] | ||
| }, | ||
| "ddosProtectionPlan": { | ||
| "id": "[resourceId('Microsoft.Network/ddosProtectionPlans', parameters('moodleCommon').ddosPlanName)]" | ||
| }, | ||
| "enableDdosProtection": "[parameters('moodleCommon').ddosSwitch]" | ||
| } | ||
| } | ||
| ], | ||
| "variables": { | ||
| "documentation01": "This sub-template creates a Azure DDoS protection plan and link it to a vnet" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. So you did confirm that this works regardless of whether this vnet already exists or is to be created, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've ran 4 tests
Each one of these 4 deployment succeed and I can browse the homepage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added documentation in the Parameters.md file and the Manage.md file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your quick follow-up. This is super! I'm merging this PR right after. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're welcome. Thanks for the great work you're doing !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is DDoS protection included with all deployments automatically?