updating nginx to wait for moodle mount with ssl cert #130#138
Merged
Conversation
hosungsmsft
approved these changes
May 30, 2018
hosungsmsft
left a comment
hosungsmsft
left a comment
There was a problem hiding this comment.
Thanks for your contribution. As I mentioned in the only comment, we'll accept this PR, but will change it soon so that it's nginx version upgrade tolerant.
|
|
||
| if [ "$webServerType" = "nginx" -o "$httpsTermination" = "VMSS" ]; then | ||
| # update startup script to wait for certificate in /moodle mount | ||
| sed -i '/After=/ s/$/ moodle.mount/' /lib/systemd/system/nginx.service && systemctl daemon-reload |
There was a problem hiding this comment.
This works, but /lib/system/system/nginx.service may get overwritten if nginx version is upgraded.
I've been investigating how to fix this properly, and found that the correct location is /etc/systemd/system/nginx.service.d/override.conf. I was working on making that change, and in the meantime you beat me, which I'm very grateful for.
We'll accept this PR and change further to update the right conf file.
naioja
pushed a commit
that referenced
this pull request
Dec 29, 2025
updating nginx to wait for moodle mount with ssl cert #130
vibehero100
pushed a commit
to vibehero100/Moodle
that referenced
this pull request
Apr 7, 2026
updating nginx to wait for moodle mount with ssl cert Azure#130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.