Skip to content

Added ability to detect optionality for each Parameter#68

Merged
vicperdana merged 8 commits intoAzure:mainfrom
vicperdana:main
Mar 30, 2021
Merged

Added ability to detect optionality for each Parameter#68
vicperdana merged 8 commits intoAzure:mainfrom
vicperdana:main

Conversation

@vicperdana
Copy link
Copy Markdown
Contributor

@vicperdana vicperdana commented Mar 25, 2021

PR Summary

Added ability to detect "Required" or "Optional for each parameter. Closes #55

  • Detects if parameter is either "Optional" or "Required" based on the availability of DefaultValue or AllowedValues

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress

@vicperdana vicperdana requested a review from BernieWhite March 25, 2021 11:15
@vicperdana vicperdana requested a review from a team as a code owner March 25, 2021 11:15
Description = ''
DefaultValue = $Null
AllowedValues = $Null
Required = "Required"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vicperdana Potentially this can be localized as well since it will be part of the output.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BernieWhite just to clarify, would this be related to:
$LocalizedData.Required in line number 238.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vicperdana More suggesting that we Required now Yes / No can be localized.

So at some point, if someone wants to localize PSDocs.Azure then Yes/ No can be specified in another language.

I've added the suggestion as a commit.

@BernieWhite
Copy link
Copy Markdown
Contributor

@vicperdana All good 🥇 Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add parameter type and require column to template doco

2 participants