MAINT: Message Normalizer Refactor #1296
Open
+2,377
−1,043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlundeen2
commented
Dec 31, 2025
| api_key: Optional[str] = None, | ||
| chat_message_normalizer: ChatMessageNormalizer = ChatMessageNop(), | ||
| model_name: str = "", | ||
| message_normalizer: Optional[MessageListNormalizer] = None, |
Contributor
Author
There was a problem hiding this comment.
This class was so messy, very happy about finally cleaning it up :D
Contributor
|
We're removing an entire module that users might have interacted with so this is most definitely BREAKING. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
MessageNormalizerabstraction to standardize how PyRIT converts Message objects into formats required by different LLM targets or situations. Or, as an example, to translate Message to a string that could be understood in a system prompt. It also adds documentation and improves test coverage.This is an update to the old ChatMessageNormalizer class. This also refactors AzureMLTarget which made use of this, and removed other legacy places that used
ChatMessage.Note: this is part of a bigger change to normalize
prepended_conversationsfor attacks. To see a prototype of that, see d647054