[Bug Report]: Duplicate code Microsoft.Networking/networkSecurityGroups

[JulienFloris]

Describe the bug

@MrMCake,
Is there a reason why there is duplicated code in /Microsoft.Network/networkSecurityGroups/deploy.bicep

This is introduced with pull request #1102

There is a input param "securityRules" that deploy the Security Rules in the Parent Resource and then for a second time with the same input param for the child resource.
And both seem to deploy the exact same thing.

To reproduce

.

Code snippet

No response

Relevant log output

No response

[AlexanderSehr]

Hey @JulienFloris you're absolutely right. It's the same case for, for example, virtual network - subnet.

From a consumer pespective it makes no sense to have the duplicated code. However, from a CI perspective we need it to test the child module (in this case securityGroups) through the parent.

By the way, the intuitive solution would be to only keep the child and remove the property from the parent deployment (i.e resource networkSecurityGroup 'Microsoft.Network/networkSecurityGroups@2021-05-01' = { (...) }) however, this would actually lead to the NSG removing all rules when deploying the resource (because the property would be considered null), and then adding them again when deploying the children. Unfortunately, that is by design and outside of our scope :/

[AlexanderSehr]

I hope this makes sense. I will close the bug for now. Feel free to re-open it again if anything is unclear and I'll try to elaborate :)

[JulienFloris]

@MrMCake,
thank you for the fast response.
I'll believe it makes some sense form a CI perspective, but what is the reason to have the child resource at all in this situation then?

If the parent resource has more properties you could use the child resource to only deploy/alther the rules set, but the parent resource only has the one property "securityRules".